Add test case that wrapped keys cannot be committed or erased#424
Open
padelsbach wants to merge 2 commits into
Open
Add test case that wrapped keys cannot be committed or erased#424padelsbach wants to merge 2 commits into
padelsbach wants to merge 2 commits into
Conversation
padelsbach
force-pushed
the
add-keywrap-nvm-block-test
branch
from
1be06f3 to
6b2ce90
Compare
bigbrett
requested changes
Jul 2, 2026
| * - This invariant prevents an unwrapped key from shadowing a protected NVM | ||
| * entry, so commit and erase must reject a wrapped key id | ||
| */ | ||
| static int _testWrappedKey_UnwrapCache_NoNvmPersist( |
Contributor
There was a problem hiding this comment.
Why is this test in the multiclient test group? It only uses one client
Contributor
Author
There was a problem hiding this comment.
I had grouped all the keywrap tests together there.
I moved the two single client keywrap tests over to the client-server group
padelsbach
force-pushed
the
add-keywrap-nvm-block-test
branch
from
1400fbe to
eef14b7
Compare
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #424
No scan targets match the changed files in this PR. Review skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to F-4707 (false positive)